Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes MV3 and many Geneanet improves #130

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

pquenee
Copy link
Collaborator

@pquenee pquenee commented Sep 11, 2024

I fix a bug in background.js in the complex use in ".then" .
I introduce a delay to bypass nginx limitations.
In geneanet improved name detection and various formatting and filtering, date recovery ...
Everything is far from perfect, but this version optimizes the copy on geneanet

popup.js Outdated Show resolved Hide resolved
@eljeffeg
Copy link
Owner

I haven't had time to review, but @GuyKh can merge. Whenever we're ready to push a new version out, just let me know and I'll send it off to the browsers.

@GuyKh
Copy link
Collaborator

GuyKh commented Dec 12, 2024

@eljeffeg. I can merge, but I really want some eyes on the changes. Don't feel I'm fully understand all the changes.

buildform.js Outdated Show resolved Hide resolved
@pquenee
Copy link
Collaborator Author

pquenee commented Dec 29, 2024

Sorry for my silence, I don't check my email attached to gitHub frequently. I can be reached directly at [email protected]
I'm not a great specialist in Javascript, HTML and others, but I've been trying to survive in computer code for 50 years. (from IBM360 to Pick.system R83 and many others). I try, as much as possible, not to damage what I touch. Sincerely

@eljeffeg
Copy link
Owner

@DanCornett can you test these pull requests. I don't have time to try them but would love to get them merged, but don't want to blindly do it without testing.

@@ -35,16 +35,17 @@ registerCollection({
},
"collectionMatch": function(url) {
url = url.replace("://www.", "://");
lgurl = url.match(/org\/[a-z]{2}/)[0].replace(/org\//,'');//2 5 2024 new url of FS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there are some locale codes which are longer

@DanCornett
Copy link
Contributor

I've been testing the branch from @pquenee ... (I opened discussion asking about the "state of consolidation").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants